Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esplora fee estimate not found #364

Closed
gregdhill opened this issue Sep 24, 2024 · 1 comment
Closed

Esplora fee estimate not found #364

gregdhill opened this issue Sep 24, 2024 · 1 comment
Labels
prio:low nice to have

Comments

@gregdhill
Copy link
Contributor

Sometimes the fee estimate endpoint will return an incomplete object:

curl https://btc-testnet.gobob.xyz/fee-estimates | jq .

{
  "504": 5.026000000000001,
  "144": 5.026000000000001,
  "1008": 5.026000000000001
}

This only happens on testnet, we should allow getFeeEstimate to return the nearest value (to the number of confirmations) or default to one.
@gregdhill gregdhill mentioned this issue Sep 25, 2024
Closed
@gregdhill gregdhill added the prio:low nice to have label Sep 25, 2024
@gregdhill
Copy link
Contributor Author

Closing for this reason: #365 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio:low nice to have
Projects
Backlog
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add loop to find closest target's fee estimate bob-collective/bob
1 participant
@gregdhill