Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add loop to find closest target's fee estimate #365

Closed
wants to merge 6 commits into from

Conversation

slavastartsev
Copy link

@slavastartsev slavastartsev commented Sep 25, 2024

Closes #364

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 37584e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 0:23am

sdk/src/esplora.ts Outdated Show resolved Hide resolved
@gregdhill
Copy link
Contributor

Not sure we should fix it like this actually, I think the method should throw an error if the confirmation target isn't available. We are also trying to get around testnet being broken, if we change anything it should be in the UI or sats-wagmi - maybe hardcode the value to 1 instead in that case as it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Esplora fee estimate not found
2 participants