Mt and aa2 #91
Mt and aa2 #91
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| # Dummy oracle: 0x31b36BB047f6D5e3B49E95c4c99Cce4591e82E3f | ||
| # Dummy oracle: 0x6669d0C53fCf30c00F5AbE5a32cFa2EaD2bc2d5a |
There was a problem hiding this comment.
NIT: Might be useful to add which asset price those oracle report.
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity 0.8.18; | |||
| pragma solidity ^0.8.13; | |||
There was a problem hiding this comment.
I was thinking whether we should lock the compiler version or not, I would suggest to do so if we are done with the development, as per the best practices: https://consensys.github.io/smart-contract-best-practices/development-recommendations/solidity-specific/locking-pragmas/
There was a problem hiding this comment.
Aside from the security implications, it can also help us with verifying the deployed bytecode.
There was a problem hiding this comment.
Ok yea will keep that in mind, but it was giving me compilation errors so I changed it. We'll see if we can lock version prior to mainnet launch
| function _msgSender() internal view override(Context, ERC2771Recipient) returns (address sender) { | ||
| sender = ERC2771Recipient._msgSender(); | ||
| } | ||
|
|
||
| function _msgData() internal view override(Context, ERC2771Recipient) returns (bytes calldata) { | ||
| return ERC2771Recipient._msgData(); | ||
| } |
There was a problem hiding this comment.
Why is it needed to override these functions when they return the same value as if they weren't overrode?
No description provided.