Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PHPUnit 9 #404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump to PHPUnit 9 #404

wants to merge 1 commit into from

Conversation

nterray
Copy link

@nterray nterray commented Aug 22, 2022

Running tests of Mustache.php on a PHP 8.1 environment requires to bump
PHPUnit to a recent version.

  • Configuration file has been updated with phpunit --migrate-configuration
  • PHPUnit_Framework_TestCase is replaced by \PHPUnit\Framework\TestCase
  • assertContains is replaced by assertStringContainsString
  • @expectedException annotation is replaced by $this->expectException
  • setUp() and setUpBeforeClass() should match parent implementation

Note: $this-assertTrue(true); has been added to avoid risky tests
(tests without assertions).

friendsofphp/php-cs-fixer has also been bumped to its latest version
during the update process.

Running tests of Mustache.php on a PHP 8.1 environment requires to bump
PHPUnit to a recent version.

* Configuration file has been updated with `phpunit --migrate-configuration`
* PHPUnit_Framework_TestCase is replaced by \PHPUnit\Framework\TestCase
* `assertContains` is replaced by `assertStringContainsString`
* `@expectedException` annotation is replaced by `$this->expectException`
* `setUp()` and `setUpBeforeClass()` should match parent implementation

Note: `$this-assertTrue(true);` has been added to avoid risky tests
(tests without assertions).

friendsofphp/php-cs-fixer has been also bumped to its latest version
during the update process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants