Add bocoup/aria-at as a submodule & implement processing of automated test format #2
Conversation
zcorpan
force-pushed
the
submodule-aria-at
branch
from
141b93d to
369c048
Compare
zcorpan
force-pushed
the
submodule-aria-at
branch
from
369c048 to
2927b95
Compare
Also apply to assert_checked and fix a bug to support all 3 states.
There was a problem hiding this comment.
This is all very exciting! Let a few comments that were mostly small readability requests.
Also, the naming conventions here are very inconsistent. There is a mix of python and js style. You probably want to run PEP8. https://pypi.org/project/pep8/ https://pep8.org/#prescriptive-naming-conventions
| @@ -46,3 +46,7 @@ | |||
| [submodule "include/cldr"] | |||
| path = include/cldr | |||
| url = https://github.com/unicode-org/cldr.git | |||
| [submodule "include/w3c-aria-at"] | |||
| path = include/w3c-aria-at | |||
| url = https://github.com/bocoup/aria-at | |||
There was a problem hiding this comment.
This repo has been officially moved to the w3c.
There was a problem hiding this comment.
This is intentional, because the PR that adds the JSON test is in a branch of bocoup's fork.
| _builtIn.log(obj) | ||
| for command, args in obj.items(): | ||
| if command == 'nav': | ||
| # TODO(zcorpan): this should open the file directly, not use iframe. |
There was a problem hiding this comment.
I'm not sure if you want to be leaving the TODO around.
There was a problem hiding this comment.
Yes, for now. Fixing this would need further changes to NVDA's system test code which I didn't want to mess with too much for the prototype.
|
@rmeritz Thanks! I believe I have addressed your comments. |
See w3c/aria-at#349
Also see w3c/aria-at#350
This works -- the test runs and passes all assertions. Putting it up here for review and discussion. The w3c/aria-at repo should have a way to generate files in this format from the test source material, before adopting this in the main nvaccess/nvda repo.