Open
Conversation
bettiolm
reviewed
Nov 18, 2019
| public: // member types | ||
|
|
||
| using tag_type = int; | ||
| using rank_type = int; |
There was a problem hiding this comment.
using future_type = cont_detail::any_future
| std::function<void(message_arg_type, rank_type, tag_type)> m_cb; | ||
| rank_type m_rank; | ||
| tag_type m_tag; | ||
| cont_detail::any_future m_future; |
There was a problem hiding this comment.
Suggested change
| cont_detail::any_future m_future; | |
| future_type m_future; |
| private: // implementation | ||
|
|
||
| template<typename Comm, typename Message, typename CallBack> | ||
| request send(Comm& comm, Message& msg, rank_type dst, tag_type tag, CallBack&& cb, std::false_type) |
| request send(Comm& comm, Message& msg, rank_type dst, tag_type tag, CallBack&& cb, std::false_type) | ||
| { | ||
| using V = typename Message::value_type; | ||
| request req{std::make_shared<cont_detail::request_state>()}; |
There was a problem hiding this comment.
maybe another typedef for cont_detail::request_state?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a thread-safe continuation communicator (which has thread-safe lock-free queues) we can dispatch transports to a thread pool and attach "continuations" using callbacks!
feedback is welcome!