Conversation
|
|
||
| gridtools::ghex::tl::context<gridtools::ghex::tl::mpi_tag> context(1,MPI_COMM_WORLD); | ||
|
|
||
| auto token = context.get_token(); |
There was a problem hiding this comment.
| auto token = context.get_token(); | |
| auto token = context.get_token(); | |
| EXPECT_TRUE(token == 0); |
??
There was a problem hiding this comment.
I still need to write proper tests
include/ghex/threads/mutex.hpp
Outdated
| #include <mutex> | ||
| #include <atomic> | ||
|
|
||
| namespace gridtools { |
There was a problem hiding this comment.
Why this and not using just std facilities?
include/ghex/threads/context.hpp
Outdated
| boost::callable_traits::return_type_t<F>>::type; | ||
|
|
||
| #ifndef GHEX_THREAD_SINGLE | ||
| struct context |
There was a problem hiding this comment.
I do not know if context is the right name here, maybe primitives is a better choice. Are we assuming there may be more types of primitives around, like non-busy-waiting, hpx, omp, etc..?
There was a problem hiding this comment.
I agree with the name change. I guess there will be different primitives around, so I will change the name to atomic_primitives
| class parallel_context | ||
| { | ||
| public: // members | ||
| using thread_context_type = ::gridtools::ghex::threads::context; |
There was a problem hiding this comment.
Would it make sense to make this a template parameter? I will then be responsibility of the configs to set the proper combination of factors
There was a problem hiding this comment.
template parameter makes sense
2 participants
No description provided.