refactor(signature): slight naming

boklisten · Aug 13, 2024 · e5913a2 · e5913a2
1 parent a40d179
commit e5913a2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/collections/signature/helpers/signature.helper.ts b/src/collections/signature/helpers/signature.helper.ts
@@ -126,7 +126,7 @@ export async function signOrders(
   );
 }
 
-export async function guardianSignatureRequired(
+export async function isGuardianSignatureRequired(
   userDetail: UserDetail,
   signatureStorage: BlDocumentStorage<Signature>,
 ) {

diff --git a/src/collections/signature/operations/check-guardian-signature.operation.ts b/src/collections/signature/operations/check-guardian-signature.operation.ts
@@ -9,7 +9,7 @@ import { BlCollectionName } from "../../bl-collection";
 import { userDetailSchema } from "../../user-detail/user-detail.schema";
 import {
   getValidUserSignature,
-  guardianSignatureRequired,
+  isGuardianSignatureRequired,
   isUnderage,
 } from "../helpers/signature.helper";
 import { Signature, signatureSchema } from "../signature.schema";
@@ -49,7 +49,7 @@ export class CheckGuardianSignatureOperation implements Operation {
     }
 
     if (
-      !(await guardianSignatureRequired(userDetail, this._signatureStorage))
+      !(await isGuardianSignatureRequired(userDetail, this._signatureStorage))
     ) {
       const signature = await getValidUserSignature(
         userDetail,

diff --git a/src/collections/signature/operations/guardian-signature.operation.ts b/src/collections/signature/operations/guardian-signature.operation.ts
@@ -11,7 +11,7 @@ import { orderSchema } from "../../order/order.schema";
 import { userDetailSchema } from "../../user-detail/user-detail.schema";
 import {
   deserializeBase64EncodedImage,
-  guardianSignatureRequired,
+  isGuardianSignatureRequired,
   serializeSignature,
   signOrders,
 } from "../helpers/signature.helper";
@@ -48,7 +48,7 @@ export class GuardianSignatureOperation implements Operation {
     );
 
     if (
-      !(await guardianSignatureRequired(userDetail, this._signatureStorage))
+      !(await isGuardianSignatureRequired(userDetail, this._signatureStorage))
     ) {
       throw new BlError(
         "Valid guardian signature is already present or not needed.",