Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHK-3367: fix shipping line fee #28

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

bold-nima
Copy link
Contributor

Jira Issue

Description

This fixes the issue where when we change the shipping method the amount doesn't get updated. We want to use code instead of index.

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce the testing. Also, list any relevant details for your test configuration.

Checklist

  • I have tested this change myself
  • I have created specs/tests for these changes (if applicable)
  • I have updated the documentation (if applicable)
  • I have bumped the version by more than 1 - ex. 1.0.1-build.344 becomes 1.0.1-build.346

Repo Resources

Below are two shops with META that can be used for QA-ing

Internal Production Store

Internal Staging Store

Copy link

swarmia bot commented Aug 9, 2024

@bold-nima bold-nima force-pushed the CHK-3367-fix-shipping-line-fee branch from d37f669 to 6dcfedb Compare August 9, 2024 15:46
@bold-nima bold-nima force-pushed the CHK-3367-fix-shipping-line-fee branch from 6dcfedb to 44b7f3e Compare August 9, 2024 20:16
@bold-nima bold-nima merged commit 1d32940 into main Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants