Maybe remove the panic when creating a new client

[uginroot]

go-shopify/goshopify.go

Line 245 in f29f869

panic(err) // something really wrong with shopName

How is my code working now:

import (
    goshopify "github.com/bold-commerce/go-shopify"
    "net/url"
)
func NewClient(app goshopify.App, shopName string, token string) (*goshopify.Client, error){
    _, err := url.Parse(shopName)
    
    if err != nil {
        return nil, err
    }

    return app.NewClient(shopName, token), nil
}

I think it would be right:

func (a App) NewClient(shopName, token string, opts ...Option) (*Client, error) {
	return NewClient(a, shopName, token, opts...)
}
func NewClient(app App, shopName, token string, opts ...Option) (*Client, error) {
    baseURL, err := url.Parse(ShopBaseUrl(shopName))
    if err != nil {
        return nil, err
    }
    //.....
}

Or:

func (a App) NewClient(shopName url.URL, token string, opts ...Option) (*Client, error) {
	return NewClient(a, shopName, token, opts...)
}
func NewClient(app App, shopName url.URL, token string, opts ...Option) (*Client, error) {
    baseURL := shopName
    //.....
}

[oliver006]

Should make this change for the upcoming breaking-changes release due to #5

[oliver006]

Tackling this in #258

[oliver006]

v4.0.0 was released - this should be fixed.