Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards incompatible changes for 4.0 #258

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Backwards incompatible changes for 4.0 #258

merged 6 commits into from
Jan 31, 2024

Conversation

oliver006
Copy link
Collaborator

@oliver006 oliver006 commented Jan 14, 2024 •
edited
Loading

@oliver006 oliver006 added the 4.0 Will address this in the next major release, either because it's a breaking change or major effort. label Jan 14, 2024
@oliver006 oliver006 self-assigned this Jan 14, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff955b4) 100.00% compared to head (2c9c92e) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         2198      2207    +9     
=========================================
+ Hits          2198      2207    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Jan 14, 2024
Closed
Closed
Closed
Closed
@oliver006 oliver006 changed the base branch from new_4.x to master January 14, 2024 05:56
This was referenced Jan 22, 2024
Closed
Closed
Closed
BoldBrandonM
BoldBrandonM requested changes Jan 25, 2024
View reviewed changes
Copy link

@BoldBrandonM BoldBrandonM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing here I see that I'm not keen on is the constructor panic. Looks great otherwise!

README.md Outdated Show resolved Hide resolved
abandoned_checkout.go Show resolved Hide resolved
goshopify.go Show resolved Hide resolved
@oliver006 oliver006 force-pushed the oh_towards_4.x branch 2 times, most recently from b6d17a0 to 3dd57f3 Compare January 26, 2024 18:13
BoldBrandonM
BoldBrandonM previously approved these changes Jan 29, 2024
View reviewed changes
@oliver006 oliver006 marked this pull request as ready for review January 31, 2024 05:12
BoldBrandonM
BoldBrandonM reviewed Jan 31, 2024
View reviewed changes
Copy link

@BoldBrandonM BoldBrandonM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some changes to customer and order APIs were pulled in, are they related to the breaking changes?

@oliver006
Copy link
Collaborator Author

Looks like some changes to customer and order APIs were pulled in, are they related to the breaking changes?

I did some merging - rebasing after the recent PRs #260 and #261 and #259 which modified order.go and customer.go but I just looked at the diff here and it seems fine. Anything sticking out that shouldn't be there?

@BoldBrandonM
Copy link

Looks like some changes to customer and order APIs were pulled in, are they related to the breaking changes?

I did some merging - rebasing after the recent PRs #260 and #261 and #259 which modified order.go and customer.go but I just looked at the diff here and it seems fine. Anything sticking out that shouldn't be there?

Oh I was just looking at the diff between the pushes, but if that's just from the master branch then no worries.

BoldBrandonM
BoldBrandonM approved these changes Jan 31, 2024
View reviewed changes
Copy link

@BoldBrandonM BoldBrandonM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving, as this latest change was only master rebases.

@oliver006 oliver006 merged commit d631571 into bold-commerce:master Jan 31, 2024
5 checks passed
@oliver006 oliver006 deleted the oh_towards_4.x branch January 31, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoldBrandonM BoldBrandonM BoldBrandonM approved these changes

Assignees

@oliver006 oliver006

Labels
4.0 Will address this in the next major release, either because it's a breaking change or major effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver006 @BoldBrandonM