Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handle field to shipping lines #249

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Conversation

serezha93
Copy link

@sx328
Copy link

sx328 commented Nov 16, 2023

this field described here https://shopify.dev/docs/api/admin-rest/2023-07/resources/draftorder

lgtm!

oliver006
oliver006 previously approved these changes Nov 17, 2023
Copy link
Collaborator

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@oliver006
Copy link
Collaborator

Change looks ok but the tests are unhappy - can you have a look plz?

@sx328
Copy link

sx328 commented Nov 18, 2023

=== RUN   TestShippingLines_UnmarshallJSON
    order_test.go:1165: ShippingLines.Handle should be (test), was (third_party_handle)
--- FAIL: TestShippingLines_UnmarshallJSON (0.00s)
=== RUN   TestShippingLines_UnmarshallJSON_RequestFulfillmentServiceIDNumber
    order_test.go:1165: ShippingLines.Handle should be (test), was ()
--- FAIL: TestShippingLines_UnmarshallJSON_RequestFulfillmentServiceIDNumber (0.00s)
=== RUN   TestShippingLines_UnmarshallJSON_RequestFulfillmentServiceIDNull
    order_test.go:1165: ShippingLines.Handle should be (test), was ()
--- FAIL: TestShippingLines_UnmarshallJSON_RequestFulfillmentServiceIDNull (0.00s)

these specific tests seem to be failing. should be an easy fix.

@serezha93
Copy link
Author

yep, I fixed tests

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (030224d) 100.00% compared to head (c83ae20) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #249   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2133      2133           
=========================================
  Hits          2133      2133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@oliver006 oliver006 merged commit 25ac74a into bold-commerce:master Nov 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants