Add ArticlesService in the client #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver006
reviewed
Sep 22, 2024
articles_test.go
Outdated
| import ( | ||
| "context" | ||
| "fmt" | ||
| "github.com/jarcoal/httpmock" |
There was a problem hiding this comment.
nit: break out the 3rd party import in a separate section
Implement ArticlesService for managing Shopify articles, including CRUD operations, tag related operations, and article count.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 99.87% 99.11% -0.76%
==========================================
Files 52 53 +1
Lines 2320 2363 +43
==========================================
+ Hits 2317 2342 +25
- Misses 2 20 +18
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can someone merge this? I was just about to create a new issue about the missing Articles services |
oliver006
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ArticlesService for managing Shopify articles, including CRUD operations, tag related operations, and article count.