bombastictranz/monitoring-dashboard-samples #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bombastictranz
commented
Mar 14, 2024
bombastictranz
commented
Stock control supervisors
…port. This makes import.sh usable on default MacOS terminal. Without this change import.sh was erroring out: ``` To upload these dashboard(s) manually, you can run: ./upload.sh reports/2024-3-12/08:07:43/ <PROJECT_ID> END grep: invalid option -- P usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] ``` Due to MacOS shipping [BSD version of grep without Perl option.](https://stackoverflow.com/questions/77662026/grep-invalid-option-p-error-when-doing-regex-in-bash-script#comment136915500_77662026) Signed-off-by: bwplotka <bwplotka@gmail.com>
Consul Prometheus dashboard KPI and layout updates
* Update HBase Prometheus dashboard KPIs and layout * updated title for region server operations dashboard * added filters to both dashboards and summed scorecards in overview dashboard * updated chart titles to express milliseconds as ms --------- Co-authored-by: Austin Georgiades <algchoo@gmail.com>
fix: import.sh replace grep -P with GNU param expansion for MacOS support
Co-authored-by: Varun Chandramouli <varun.c37@gmail.com>
SAP HANA + SAP NetWeaver Availability Monitoring Dashboards
Added reservation utilization alerts to google-gce.
…yout-update Argo Workflows Prometheus dashboard KPI and layout updates
Jetty Prometheus dashboard KPI and layout updates
…date Jenkins Prometheus dashboard KPI and layout updates
bombastictranz
added
bug
PR summaryThe Pull Request introduces a variety of updates to the monitoring dashboard samples for different services like NGINX, Prometheus, Google Compute Engine (GCE), Argo Workflows, Consul, HBase, Jenkins, and Jetty. These updates include new metrics, layout changes, new alerts, and fixes for compatibility issues on MacOS. SuggestionOverall, the PR seems comprehensive and well-documented. However, it's important to ensure that the new metrics and alerts added are thoroughly tested to confirm they are accurately reflecting the system's state and that the alerts are correctly configured to notify users as expected. Additionally, it would be beneficial to update any associated documentation to reflect these changes and guide users on how to leverage the new metrics and alerts. Changes in the Pull Request
Implications and Impact
Notable Changes per File
Additional Notes
Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect. Current plan usage: 27.00% Have feedback or need help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.