Make libfaac optional #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to script out the fetching of the other repository. Submodule stores the version of the sub-repository.
Previously, since the introduction of the streamer support in version 2.0.0, it was impossible to compile the daemon without a dependency on libfaac. This prevented the daemon from being built on Debian systems without `non-free` repositories enabled. It seems the issue with libfaac is that it is based on code with a non-DFSG compliant license. This commit introduces a new config option WITH_STREAMER which is ON by default, causing the behaviour to stay backwards-compatible with the one before this commit. It is newly possible to pass `-DWITH_STREAMER=OFF` to cmake to build without streamer support and without the dependency on libfaac.
aes67-daemon: Make dependency on libfaac optional
Use cpp-httplib via a submodule.
- changed cpp-httplib git submodule path to https://github.com/bondagit/cpp-httplib.git - removed compilation warning related to the usage of Boost bind global placeholders - updated daemon version to 2.0.2
Fix to the daemon regression test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.