chore(supertest): add property-based tests for HTTP response assertions #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive property-based tests for all 14 HTTP response assertions in @bupkis/supertest, following the established pattern from @bupkis/sinon. The implementation uses fast-check to generate randomized test inputs and validate assertion behavior across the input space.
Changes:
- Added
property.test.tswith 56 property-based tests covering status code, header, body, and redirect assertions - Exported individual assertion functions from
assertions.tsfor test access (previously only exported the array) - Removed unnecessary express/supertest dependencies that were mistakenly added in a previous commit
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/supertest/test/property.test.ts | New comprehensive property-based test suite with helper arbitraries for HTTP response generation and test configurations for all 14 assertions |
| packages/supertest/src/assertions.ts | Exported individual assertion functions to enable test access while maintaining backward compatibility |
| packages/supertest/package.json | Added fast-check as devDependency, removed unnecessary express/supertest dependencies |
| package-lock.json | Cleaned up dependency tree by removing express, supertest, and their transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
boneskull
force-pushed
the
supertest-prop-tests
branch
from
6b54412 to
fb32dc4
Compare
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
boneskull
changed the title
This adds comprehensive property tests for all 14 @bupkis/supertest assertions using @bupkis/property-testing and fast-check. The tests generate random HTTP responses and validate assertion behavior across the input space. Changes: - Export individual assertions for testing access - Add property test configs for status code assertions (2) - Add property test configs for header assertions (3) - Add property test configs for body assertions (6) - Add property test configs for redirect assertions (3) - Create helper arbitraries for HTTP response generation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
boneskull
force-pushed
the
supertest-prop-tests
branch
from
fb32dc4 to
a4a3953
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@bupkis/supertestassertionsassertions.tsfor test access (matching@bupkis/sinonpattern)Test Coverage
Test Plan
@bupkis/sinonproperty tests🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com