fix(bupkis): support expect.it() in error-satisfying assertions

[boneskull]

The 'to throw error satisfying', 'to reject with error satisfying', and
similar assertions had special handling for string/RegExp parameters that
bypassed valueToSchema, causing expect.it() functions to fail validation.

Changed the final else-if branch to a plain else clause, letting
valueToSchema handle all non-string/non-RegExp parameters including
ExpectItExecutor functions.

Also expanded property test generators to include expect.it() cases
for better coverage of these assertions.

[boneskull]

• fix(bupkis): support expect.it() in error-satisfying assertions #342 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR fixes a bug where expect.it() functions failed when used within error-satisfying assertions. The root cause was that the special handling for string/RegExp parameters bypassed valueToSchema, which properly handles ExpectItExecutor functions.

Changes:

• Modified error-satisfying assertions to delegate all non-string/non-RegExp parameters to valueToSchema
• Removed unnecessary error handling and type guards since valueToSchema always returns a valid schema
• Expanded test generators to include expect.it() cases for better coverage

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
packages/bupkis/src/assertion/impl/sync-parametric.ts	Changed conditional logic from else if (isNonNullObject(param)) to else to allow valueToSchema to handle all parameter types; removed unnecessary error handling code
packages/bupkis/src/assertion/impl/async-parametric.ts	Applied same conditional logic fix for async assertions; consistent with sync changes
packages/bupkis/test-data/sync-parametric-generators.ts	Added test generators for expect.it() cases in satisfies and error-satisfying assertions
packages/bupkis/test-data/async-parametric-generators.ts	Added test generators for expect.it() cases in async error-satisfying assertions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.