Skip to content

Add /warnVacuousProofs option #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 28, 2025
Merged

Conversation

atomb
Copy link
Collaborator

@atomb atomb commented Apr 22, 2025

This option enables /trackVerificationCoverage and automatically warns if it detects vacuous proofs. This is intended for the less-common case where a front end doesn't add IDs to program elements and then post-process the results.

@atomb atomb force-pushed the direct-vacuity-checks branch from 1c749a6 to 19f43f3 Compare April 22, 2025 21:49
This option enables `/trackVerificationCoverage` and automatically warns
if it detects vacuous proofs. This is intended for the less-common case
where a front end doesn't add IDs to program elements and then post-
process the results.
@atomb atomb force-pushed the direct-vacuity-checks branch from 19f43f3 to bac4ccd Compare April 22, 2025 21:51
@atomb atomb requested a review from keyboardDrummer April 22, 2025 21:57
atomb added 2 commits April 22, 2025 15:35
* Always have a set of IDs for a given procedure, even if empty.
* Don't consider `free ensures` and `assert true` to be goals.
@atomb atomb marked this pull request as draft April 23, 2025 16:47
@atomb atomb marked this pull request as ready for review April 23, 2025 17:48
@atomb atomb requested review from fabiomadge and shazqadeer April 24, 2025 15:52
atomb added 3 commits April 25, 2025 09:32
- Only add an ID if there isn't already one.
- Encode line, column, and type in autogenerated IDs.
@atomb atomb enabled auto-merge (squash) April 25, 2025 18:24
Copy link
Contributor

@fabiomadge fabiomadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

fabiomadge
fabiomadge previously approved these changes Apr 28, 2025
@atomb atomb merged commit 6d8896f into boogie-org:master Apr 28, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants