Fix download using spine info from another request

[ahxxm]

This PR is a fix for the new network requests format I described in this issue:

• in handleBookMetaWebRequest, filter for the new request instead
• extract the JSON we need from HTML window.bdata
• the parsing logic actually doesn't change much

Verified by building the extension locally, load into Firefox and download one book I borrowed several days ago, the audiofile is fully playable

Closes #161 #192 #194

[mkgtu]

Should we presume the extension will be updated in the store soon?

Out of curiosity tried installing the fork with the downloaded zip from the fork page but got the error msg "No valid manifest found".

[ahxxm]

Out of curiosity tried installing the fork with the downloaded zip from the fork page but got the error msg "No valid manifest found".

typescript browser extension is a little different, the source codes can't be used as browser extension yet, you can try my branch build here inside "Artifact" section at the bottom, and it's a nested zip file: https://github.com/ahxxm/libby-download-extension/actions/runs/8856205292

[mkgtu]

Out of curiosity tried installing the fork with the downloaded zip from the fork page but got the error msg "No valid manifest found".

typescript browser extension is a little different, the source codes can't be used as browser extension yet, you can try my branch build here inside "Artifact" section at the bottom, and it's a nested zip file: https://github.com/ahxxm/libby-download-extension/actions/runs/8856205292

I can report that I just installed your branch version in Firefox, loaded an audiobook, and
DOWNLOADED the book SUCCESSFULLY in short order, NO HICCUPS, NO GLITCHES, SMOOTH AS BUTTER. Single mp3 plus cue, as before.

Loaded it on my phone and opened it in LISTEN, SMARTAUDIOBOOK, and SIRIN players (all android) and the book played correctly, with proper CHAPTERS displayed in all their glory. (All 3 of those players can parse cue files as well as Overdrive embedded chapter tags)

In short, MAGNIFICENT. Hope its changes can be made permanent. At least till Libby throws another curve ball.

[BLS-Pro]

I can report that I just installed your branch version in Firefox, loaded an audiobook, and DOWNLOADED the book SUCCESSFULLY in short order, NO HICCUPS, NO GLITCHES, SMOOTH AS BUTTER. Single mp3 plus cue, as before.

Clueless idiot here. How exactly does one install this branch version in Firefox?

[blindsamurai777]

@BLS-Pro - Same question I had. (1) Download and extract the files; (2) follow this video exactly https://www.youtube.com/watch?v=XqWMDv411k0

Awesome @ahxxm - it works perfectly

[BLS-Pro]

@BLS-Pro - Same question I had. (1) Download and extract the files; (2) follow this video exactly https://www.youtube.com/watch?v=XqWMDv411k0

Awesome @ahxxm - it works perfectly

Thanks! That did the trick and was SOOOO easy!

[zorin1]

@ahxxm Your fix works for me. I tried it on an audio book. Great job.

[mkgtu]

Before you all get too excited you should realize that these "temporary" extensions only last till you close the browser. Next time you open it, it's gone. You have to install it again.

So we still need a permanent fix to the regular extension.

[BLS-Pro]

Yes. The ext needs to be permanently fixed. But this is an excellent solution until then - one I personally could live with even if the original ext is never fixed. :)

…

On Fri, Apr 26, 2024 at 11:35 PM mkgtu ***@***.***> wrote: Before you all get too excited you should realize that these "temporary" extensions only last till you close the browser. Next time you open it, it's gone. You have to install it again. So we still need a permanent fix to the regular extension. — Reply to this email directly, view it on GitHub <#195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BGQRW2ISUNDLWK5L2QEP3BTY7NBMJAVCNFSM6AAAAABG2YQGJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQGM4DONBYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Sent from my mobile device

[mkgtu]

Interesting that the Chrome extension is already fixed with basically the same changes and is already published in GitHub in its final form. houtianze has decided not to publish it in the Chrome Webstore anymore, I presume because of the previous issues with trademark violations. It will having to be installed going forward using a zip file from GitHub.

[mkgtu]

This workflow requires approval from the maintainer.

@bookbonobo Is that approval forthcoming any time soon? You've said you have no more time to work on this extension. Fine. But at least either approve and integrate the fix that works or turn the extension over to someone who will. You are all too noticeably absent from this process. Time to get involved.

[bookbonobo]

This workflow requires approval from the maintainer.

@bookbonobo Is that approval forthcoming any time soon? You've said you have no more time to work on this extension. Fine. But at least either approve and integrate the fix that works or turn the extension over to someone who will. You are all too noticeably absent from this process. Time to get involved.

I came here on my weekend to do exactly that - test this PR, merge it and go through the Firefox release process to push it out to folks. But this kind of entitlement isn't welcome here. If you think you can do a better job the beauty of open source is that you can get involved just like @ahxxm did putting this PR together. Fork it yourself and publish something, or constrain yourself to more constructive comments @mkgtu. If you have the expertise to be a maintainer I'm happy to talk about it.

Thank you for the fix @ahxxm this is great!

[bookbonobo]

See #196 for a continuation of the discussion around maintainers.

[BLS-Pro]

It would appear this problem has returned. Others have reported, and I have confirmed, that when trying to download an audiobook, the ext now returns the error: "Task: Loading State; Status: Failed"

[ahxxm]

it's a different error, they are putting the following into window.bdata:{"title":"Terms & Conditions: https://company.cdn.overdrive.com/policies/terms-and-conditions","paths":[null],"offset":0}

the ToC prohibits any action they might consider a "transfer or misuse"

redistribute, repackage, transmit, assign, sell, broadcast, publicly display, rent, share, lend, modify, extract, reveal, adapt, edit, sub-license and/or otherwise transfer or misuse the Content;

the vagueness is very concerning, and it reminds me of fair use

[BLS-Pro]

"it's a different error"

Right. Does anyone know of/have a way around the problem?

[zorin1]

@ahxxm Do you think that you can create a fix? Or am I back to playing the audio book and recording it while it plays. :)

[ahxxm]

I do have several workarounds to play audiobook with local a player, but don't have a fix like this PR