Open
Conversation
dogezen
reviewed
Jul 31, 2024
src/server.js
Outdated
|
|
||
| module.exports = app | ||
| app.post("/contacts", function (req, res) { | ||
| const postContact = req.body; |
There was a problem hiding this comment.
it's better practice to extract out the variables, to avoid accepting any input that may come from the POST body:
const { title, content } = req.bodyIf for example req.body = {title, content, someUnknownProperty} with the code in my example, the someUnknownProperty is ignored, but with your code it would be included.
| module.exports = app | ||
| app.post("/contacts", function (req, res) { | ||
| const postContact = req.body; | ||
| const currentHighId = contacts.reduce((max, obj) => { |
There was a problem hiding this comment.
nice, you could make this a generic function in a utils.js file :
function getNextId(items) {
return items.reduce(...) + 1
}and then call your function when needed, makes the code tidier
| }); | ||
|
|
||
| app.get("/contacts/:id", function (req, res) { | ||
| const toFind = parseInt(req.params.id, 10); |
There was a problem hiding this comment.
the name of this var is not great, it'd be better to use targetId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unfinished