Conversation
|
|
||
| <div class="user"> | ||
| <div class="profile-pic"> | ||
| <img src="./svgFiles/Hello Ctulhu! black letters.jpg" alt="" width="45px"> |
There was a problem hiding this comment.
I would avoid having spaces and special characters (!) in file names, they can cause unexpected issues on certain systems. Better to go with underscores and dashes just to be safe
| </g> | ||
| </svg> | ||
|
|
||
| <!-- <div class="icon-spacer"></div> --> |
There was a problem hiding this comment.
Try not to commit dead code like this. We can always go back to previous commits, that's what git is for, so don't worry about keeping things you might need in future
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
There's a lot of chaotic white space in this file...
| display: grid; | ||
| grid-template: | ||
| 'header main news' / | ||
| 25% 1fr 30% |
There was a problem hiding this comment.
It can be difficult to work with %'s for layouts, it's better to define fixed pixel widths for side bars and change them with media queries at certain break points
There was a problem hiding this comment.
Oh god! And I thought that %'s will be better for responsive design since analogy stays constant no matter what the actual size is. Duly noted as are the rest of your remarks.
2 participants
No description provided.