Hamada Abdelaal #155
Open
Hamada Abdelaal #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vherus
reviewed
Mar 18, 2024
Comment on lines
+10
to
+13
| <!------ Grid container------> | ||
| <div class="container"> | ||
| <!------ left-hand menu------> | ||
| <nav class="left-hand-menu"> |
There was a problem hiding this comment.
These comments are redundant, your css classes and semantic nav element clearly describe the purpose of the content
vherus
reviewed
Mar 18, 2024
Comment on lines
+1
to
+7
| :root { | ||
| --primary-font-color: #0f141a; | ||
| --secondary-font-color: #546373; | ||
|
|
||
| --placeholder-font-color: #989797; | ||
|
|
||
| --search-bar-focus-b-color: #3d91f9; |
Author
There was a problem hiding this comment.
Thanks Nathan for your feedback and your instructions.
After we have studied semantic elements today I'll replace all unnecessary divs with the semantics one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.