Sami Saeed #156
Sami Saeed #156
Conversation
| } | ||
| .logo{ |
There was a problem hiding this comment.
You should add an empty line after every CSS block to give some breathing space, it makes it a little easier to read / maintain
| img{ | ||
| height:40px; | ||
| width:47px; | ||
| padding-left:5px | ||
| } |
There was a problem hiding this comment.
Why is this img element inside of the logo element? You can't nest css selectors inside of others, except with things like media queries. You should use specificity to target specific child elements:
.logo img {
}
| img{ | ||
| height: 25px; | ||
| } |
There was a problem hiding this comment.
Same here, you can't nest this img element inside the home-btn element
| <link rel="stylesheet" href="./new_twitter.css" /> | ||
| </head> | ||
| <body> | ||
| <div class = 'container'> |
There was a problem hiding this comment.
Don't add white space around the property/value pairs. It works, but it goes against convention - I don't know any project that uses whitespace in this way. Also, be sure to use double quotes instead of single quotes
<div class="container">
vherus
left a comment
vherus
left a comment
There was a problem hiding this comment.
Good work! Be careful with nesting CSS selectors inside of other CSS selectors
2 participants
No description provided.