Farshad Bagdeli #158
Open
Farshad Bagdeli #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vherus
reviewed
Mar 18, 2024
Comment on lines
+18
to
+29
| .logo { | ||
| grid-area: logo; | ||
| background-color: #000000; | ||
|
|
||
| svg { | ||
| padding: 10px; | ||
| height: 40px; | ||
| width: 40px; | ||
| fill: white; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
You can't nest CSS selectors inside of other selectors, you'd need to use specificity:
.logo {
grid-area: logo;
background-color: #000000;
}
.logo svg {
padding: 10px;
height: 40px;
width: 40px;
fill: white;
}
vherus
reviewed
Mar 18, 2024
Comment on lines
+31
to
+56
| .header { | ||
| grid-area: header; | ||
| width: 697; | ||
| height: 60px; | ||
| border-left: 1px solid gray; | ||
| border-right: 1px solid gray; | ||
| border-bottom: 1px solid gray; | ||
| .header-containe { | ||
|
|
||
| background-color: black; | ||
| display: grid; | ||
| grid-template-columns: 5fr 5fr 1fr; | ||
| p { | ||
| color: white; | ||
| text-align: center; | ||
| padding: 20px 0px 10px 0px; | ||
| } | ||
| svg { | ||
| fill: white; | ||
| height: 30px; | ||
| width: 30px; | ||
| padding: 15px; | ||
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Same here, and for a lot of your CSS actually. I imagine this has been causing you a bit of a headache.
vherus
reviewed
Mar 18, 2024
vherus
left a comment
vherus
left a comment
There was a problem hiding this comment.
You HTML is good, and your CSS is fine but you're nesting a lot of things in CSS. CSS shouldn't have any nesting other than with things like media queries
Author
|
@vherus Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to work on it