Mamadou Leye #165
Open
Mamadou Leye #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vherus
reviewed
Mar 18, 2024
| <!-- tweetbox starts --> | ||
| <div class="tweetBox"> | ||
| <form> | ||
| <div class="tweetbox__input"> |
There was a problem hiding this comment.
Be careful with case sensitivity. This class is tweetbox, but the others are tweetBox.
Stick with kebab-case for CSS, not camelCase
vherus
reviewed
Mar 18, 2024
Comment on lines
+8
to
+9
| --twitter-color: #50b7f5; | ||
| --twitter-background: #e6ecf0; |
vherus
reviewed
Mar 18, 2024
vherus
left a comment
vherus
left a comment
There was a problem hiding this comment.
Great work! Your code is easy to read, well constructed and mostly consistent.
Author
|
Thank you, will use kebab case from now on. I just wanted to experiment
things I have never done before with the challenge.
…On Mon, 18 Mar 2024 at 11:50, Nathan King ***@***.***> wrote:
***@***.**** commented on this pull request.
Great work! Your code is easy to read, well constructed and mostly
consistent.
—
Reply to this email directly, view it on GitHub
<#165 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGCUW624I3BO2O4O5HO52YDYY3IIJAVCNFSM6AAAAABE3EOJRCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBSG42DANBUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.