Open
Conversation
vherus
reviewed
Mar 18, 2024
Comment on lines
+17
to
+23
| <div class="sidebar"> | ||
| <i class="fab fa-twitter"></i> | ||
|
|
||
| <div class="sidebarOption active"> | ||
| <span class="material-icons"> home </span> | ||
| <h2>Home</h2> | ||
| </div> |
There was a problem hiding this comment.
Your indentation is a little off, I'm not sure where one div ends and another begins. This would be easier to maintain like this:
<div class="sidebar">
<i class="fab fa-twitter"></i>
<div class="sidebarOption active">
<span class="material-icons"> home </span>
<h2>Home</h2>
</div>
vherus
reviewed
Mar 18, 2024
|
|
||
|
|
||
| <!-- I start buiding my post section here --> | ||
| <div class="post"> |
There was a problem hiding this comment.
I don't think this div should be floating all the way at the left side of the file
vherus
reviewed
Mar 18, 2024
vherus
left a comment
vherus
left a comment
There was a problem hiding this comment.
Great work. Your indentation needs a bit of work to improve its consistency and quality, and your css should be using kebab-case instead of camelCase. Keep up the great work :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.