Skip to content

Thomas Kristiansen #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Thomaskri0801 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Thomas Kristiansen #122

Thomaskri0801 wants to merge 12 commits into from

Conversation

@Thomaskri0801
Copy link

@Thomaskri0801 Thomaskri0801 commented Jan 9, 2025

No description provided.

ninja-aruna
ninja-aruna reviewed Jan 10, 2025
View reviewed changes
src/main/java/com/booleanuk/core/TodoList.java
}
}

public ArrayList<String> viewAlphabeticalAsc() {
Copy link

@ninja-aruna ninja-aruna Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just sort the original list and return it here, rather than copying lists

ninja-aruna
ninja-aruna reviewed Jan 10, 2025
View reviewed changes
Copy link

@ninja-aruna ninja-aruna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but avoid having publicly accessible class members (task name and status for example) - use getters and setters instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ninja-aruna ninja-aruna ninja-aruna left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Thomaskri0801 @ninja-aruna