Skip to content

Magnus Krumbacher#124

Open
Magnus-droid wants to merge 9 commits intoboolean-uk:mainfrom
Magnus-droid:main
Open

Magnus Krumbacher#124
Magnus-droid wants to merge 9 commits intoboolean-uk:mainfrom
Magnus-droid:main

Conversation

@Magnus-droid
Copy link

No description provided.

Copy link

@ninja-aruna ninja-aruna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort. A few observations though:

  • Avoid having publicly accessible class members (task an,me and status for example) - use getters and setters instead
  • When you have duplicate code, like your sort methods, and change task status methods, consider combining them and introducing a method param to branch the behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants