Open
Conversation
added 22 commits
January 9, 2025 14:04
…de. listTasks result was changed in domain model.
…n the domain model
Fixed some mistakes in tasksAscending() tests and finished the code.
ninja-aruna
reviewed
Jan 13, 2025
| return true; | ||
| } | ||
|
|
||
| public List<String> listTasks(){ |
There was a problem hiding this comment.
You could just iterate over the hashmap and use a stringbuilder to output the list of tasks, rather than creating a new list
| return false; | ||
| } | ||
|
|
||
| public List<String> getCompletedTasks(){ |
There was a problem hiding this comment.
This does not seem quite right, but I think that is mostly due to the fact that you don't have a 'Task' class on which to set the 'status' property
| return strings; | ||
| } | ||
|
|
||
| public List<String> getUnCompletedTasks(){ |
Author
There was a problem hiding this comment.
Is this something I need to fix to get a passing grade or something for me to have in mind in the future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.