Mattias Hedbom #126
Open
Mattias Hedbom #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
January 9, 2025 14:21
ninja-aruna
reviewed
Jan 10, 2025
|
|
||
| HashMap<String, Boolean> tasks = new HashMap<>(); | ||
|
|
||
| public TodoList(){ |
There was a problem hiding this comment.
I am noit sure why you pre-popuate the hashmap?
ninja-aruna
reviewed
Jan 10, 2025
|
|
||
|
|
||
| // Task 3 | ||
| public boolean updateTaskStatus(String task, Boolean status){ |
There was a problem hiding this comment.
This does not look right; we should be using accessors here
added 18 commits
January 14, 2025 09:50
…g to be returned instead.
… test for Extension 4.
…the TodoItem class so it takes a LocalDateTime object. Could not figure out how to compare the dates in the test if dates where generated by LocalDateTime.now() in the constructor of TodoItem. Thus I also changed the test slightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.