Skip to content

Frida Anselin #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anselin-thefirst wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Frida Anselin #127

anselin-thefirst wants to merge 46 commits into from

Conversation

@anselin-thefirst
Copy link

@anselin-thefirst anselin-thefirst commented Jan 9, 2025

No description provided.

Frida Anselin added 15 commits January 9, 2025 14:32
First version domain model, from collaboration with peers
20a7794
testAddNewTaskToList red implementation
d47db52
Added add method to pass testAddNewTaskToList green implementation. S…
1830704 
…light change to domain model
Forgot to add test to check for already existing task, added now but …
7b563d9 
…passes immediately
Added red testListAllTasks - no code
e901abb
Corrected testListAllTasks
8724116
Add method listTasks to make testListAllTasks pass/be green + minor f…
ad01e12 
…ix to test
Added testListNoTask- red
2afd709
Add code to make testListNoTask pass - green
aed16d6
Add failing test testUpdateTaskStatusFalseToTrue - red
f181fac
Add method updateTaskStatus to pass testUpdateTaskStatusFalseToTrue -…
aae7916 
… green
Update method updateTaskStatus to pass more cases of testUpdateTaskSt…
868a461 
…atusFalseToTrue - green
Update method updateTaskStatus and test to pass more cases of testUpd…
91bedff 
…ateTaskStatusFalseToTrue - green
Add failing testListCompletedTasks - red
4f817f3
Update domain model and add not completed code for listCompletedTasks…
01bc325 
… method
ninja-aruna
ninja-aruna reviewed Jan 13, 2025
View reviewed changes
Copy link

@ninja-aruna ninja-aruna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design needs a bit more work. For example, it would be better for the todoList class to maintain the list of tasks, rather than passing the list into individual methods. Also, the tests are failing

@anselin-thefirst
Copy link
Author

anselin-thefirst commented Jan 16, 2025

Have updated the code structure in response to comment and added the remaining tests and methods for the core

Frida Anselin added 12 commits January 20, 2025 20:16
@anselin-thefirst
Copy link
Author

anselin-thefirst commented Jan 21, 2025

Added tests and methods for extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ninja-aruna ninja-aruna ninja-aruna left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anselin-thefirst @ninja-aruna