Mamadou Leye 'scrabble.js done'#206
Open
homonoviscoding wants to merge 1 commit intoboolean-uk:mainfrom
Open
Conversation
vherus
reviewed
Mar 1, 2024
| } | ||
|
|
||
| // transform input to uppercase if it is not and split the string | ||
| const input = characters.toUpperCase().split('') |
vherus
reviewed
Mar 1, 2024
| let result = 0 | ||
| // Iterate over each input letter and return 0 if the Object's properties above don't include one of the input's letters | ||
| // return in result the sum of result and the values of each Obj. properties that include input[i] in the loop. | ||
| for (let i = 0; i < input.length; i++) { |
vherus
reviewed
Mar 1, 2024
| // Iterate over each input letter and return 0 if the Object's properties above don't include one of the input's letters | ||
| // return in result the sum of result and the values of each Obj. properties that include input[i] in the loop. | ||
| for (let i = 0; i < input.length; i++) { | ||
| if (!Object.keys(pointRef).includes(input[i])) { |
Contributor
There was a problem hiding this comment.
if (!Object.keys(pointRef).includes(character))
vherus
reviewed
Mar 1, 2024
| } | ||
| return result | ||
| } | ||
| console.log(scrabble('street')) |
Contributor
There was a problem hiding this comment.
Try not to commit debug logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.