Y.Doc의 node에 isHolding property 추가 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djk01281
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔖 연관된 이슈
📂 작업 내용
node에isHoldingproperty 추가.dragStop시,false로 설정해서 보내기.📑 참고 자료 & 스크린샷 (선택)
📢 리뷰 요구사항 (선택)
isHolding입니다. 어떻게 고쳐도 마지막에false로 2번을 보내네요.. 사실 디바운싱이 목적이었으니까 일단은 이것으로 충분하지 않을까 싶긴 합니다..Object.entries()와filter()를 사용한 부분이 있는데, eslint rule과 싸워서 빌드 성공하기 위한 엄청난 사투가 있었습니다.. 😇 원래 원했던 것 :const initialNodes = yNodes.map(({ isHolding, ...node }) => node);