♻️ 리뷰 사항 반영

boostcampwm2023 · Dec 4, 2023 · 76e884a · 76e884a
1 parent 4cb3792
commit 76e884a
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 16 deletions.
diff --git a/iOS/Layover/Layover/Scenes/Playback/PlaybackInteractor.swift b/iOS/Layover/Layover/Scenes/Playback/PlaybackInteractor.swift
@@ -70,8 +70,8 @@ final class PlaybackInteractor: PlaybackBusinessLogic, PlaybackDataStore {
     }
 
     func setInitialPlaybackCell() {
-        guard let parentView else { return }
-        guard let index else { return }
+        guard let parentView,
+              let index else { return }
         let response: Models.SetInitialPlaybackCell.Response
         switch parentView {
         case .home:
@@ -124,8 +124,8 @@ final class PlaybackInteractor: PlaybackBusinessLogic, PlaybackDataStore {
     }
 
     func playTeleportVideo(with request: PlaybackModels.DisplayPlaybackVideo.Request) {
-        guard let isTeleport else { return }
-        guard let posts else { return }
+        guard let isTeleport,
+              let posts else { return }
         if isTeleport {
             if request.indexPathRow == 1 || request.indexPathRow == (posts.count - 2) {
                 let response: Models.DisplayPlaybackVideo.Response = Models.DisplayPlaybackVideo.Response(prevCell: prevCell, curCell: request.curCell)
@@ -142,8 +142,8 @@ final class PlaybackInteractor: PlaybackBusinessLogic, PlaybackDataStore {
     }
 
     func configurePlaybackCell() {
-        guard let posts else { return }
-        guard let parentView else { return }
+        guard let posts,
+              let parentView else { return }
         let response: Models.ConfigurePlaybackCell.Response
         switch parentView {
         case .home:

diff --git a/iOS/Layover/Layover/Scenes/Playback/PlaybackModels.swift b/iOS/Layover/Layover/Scenes/Playback/PlaybackModels.swift
@@ -30,11 +30,6 @@ enum PlaybackModels {
         let videoURL: URL
     }
 
-    struct PlaybackViewInfo {
-        let parentView: ParentView
-        let videos: [PlaybackVideo]
-    }
-
     // MARK: - UseCase Load Video List
 
     enum LoadPlaybackVideoList {

diff --git a/iOS/Layover/Layover/Scenes/Playback/PlaybackViewController.swift b/iOS/Layover/Layover/Scenes/Playback/PlaybackViewController.swift
@@ -146,6 +146,15 @@ final class PlaybackViewController: BaseViewController {
         playerSlider.value = Float(CMTimeGetSeconds(currentTime) / CMTimeGetSeconds(duration))
     }
 
+    private func slowShowPlayerSlider() async {
+        do {
+            try await Task.sleep(nanoseconds: 1_000_000_00)
+            playerSlider.isHidden = false
+        } catch {
+            os_log("Falie Waiting show Player Slider")
+        }
+    }
+
     @objc private func didChangedSliderValue(_ sender: LOSlider) {
         let request: Models.SeekVideo.Request = Models.SeekVideo.Request(currentLocation: Float64(sender.value))
         interactor?.controlPlaybackMovie(with: request)
@@ -173,8 +182,11 @@ extension PlaybackViewController: PlaybackDisplayLogic {
             curCell.playbackView.playPlayer()
             setPlayerSlider(at: curCell.playbackView)
             // Slider가 원점으로 돌아가는 시간 필요
-            DispatchQueue.main.asyncAfter(deadline: DispatchTime.now() + 0.1) {
-                self.playerSlider.isHidden = false
+//            DispatchQueue.main.asyncAfter(deadline: DispatchTime.now() + 0.1) {
+//                self.playerSlider.isHidden = false
+//            }
+            Task {
+                await slowShowPlayerSlider()
             }
         }
     }

diff --git a/iOS/Layover/Layover/Scenes/Playback/PlaybackWorker.swift b/iOS/Layover/Layover/Scenes/Playback/PlaybackWorker.swift
@@ -18,8 +18,8 @@ final class PlaybackWorker {
 
     func makeInfiniteScroll(posts: [Post]) -> [Post] {
         var tempVideos: [Post] = posts
-        var tempLastVideo: Post = posts[tempVideos.count-1]
-        var tempFirstVideo: Post = posts[1]
+        let tempLastVideo: Post = posts[tempVideos.count-1]
+        let tempFirstVideo: Post = posts[1]
         tempVideos.insert(tempLastVideo, at: 0)
         tempVideos.append(tempFirstVideo)
         return tempVideos

diff --git a/iOS/Layover/Layover/Scenes/Profile/ProfileModels.swift b/iOS/Layover/Layover/Scenes/Profile/ProfileModels.swift
@@ -10,6 +10,13 @@ import UIKit
 
 enum ProfileModels {
 
+    struct Member: Hashable {
+        let identifier: Int
+        let username: String
+        let introduce: String?
+        let profileImageURL: URL?
+    }
+
     enum FetchProfile {
         struct Request {
 

diff --git a/iOS/Layover/Layover/Scenes/Profile/ProfileViewController.swift b/iOS/Layover/Layover/Scenes/Profile/ProfileViewController.swift
@@ -173,7 +173,7 @@ extension ProfileViewController: ProfileDisplayLogic {
         thumbnailCollectionView.dataSource = videoDatasource
         var snapshot = NSDiffableDataSourceSnapshot<Section, AnyHashable>()
         snapshot.appendSections([.profileInfo, .thumnail])
-        snapshot.appendItems([Member(identifier: 0,
+        snapshot.appendItems([Models.Member(identifier: 0,
                                      username: viewModel.nickname,
                                      introduce: viewModel.introduce,
                                      profileImageURL: viewModel.profileImageURL)],