feat: Toast 기능 구현 #130
Merged
feat: Toast 기능 구현 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loinsir
reviewed
Nov 28, 2023
loinsir
reviewed
Nov 28, 2023
loinsir
reviewed
Nov 28, 2023
loinsir
reviewed
Nov 28, 2023
Comment on lines
46
to
52
| UIView.animate(withDuration: 1.0, delay: 0.1, animations: { | ||
| self.toastMessageLabel.alpha = 1.0 | ||
| }, completion: { _ in | ||
| UIView.animate(withDuration: 1.0, delay: 0.1, animations: { | ||
| self.toastMessageLabel.alpha = 0.0 | ||
| }) | ||
| }) |
There was a problem hiding this comment.
여기에서 delay를 주신 의미가 궁금합니다!
There was a problem hiding this comment.
토스트가 적절히 나타나도록 딜레이를 넣었습니다. 빼는게 나을까용?
loinsir
approved these changes
Nov 28, 2023
anyukyung
reviewed
Nov 28, 2023
anyukyung
reviewed
Nov 28, 2023
|
@loinsir @anyukyung 아예 갈아 엎었슴다 다시 한번 보시고 approve 해주세용 |
loinsir
reviewed
Nov 29, 2023
loinsir
reviewed
Nov 29, 2023
git push origin iOS/feat#129
anyukyung
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
Toast class를 구현했습니다.
📌 변경 사항
이런식으로 사용하면 됨다.
📸 ScreenShot
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-11-30.at.01.05.34.mp4
Linked Issue
close #129