-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 설정 뷰 UI 구현 #154
Closed
Closed
feat: 설정 뷰 UI 구현 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting이라고 해놓으면 뭔가 이상해서 Setting Scene이라고 이름 붙임
loinsir
reviewed
Nov 30, 2023
loinsir
reviewed
Nov 30, 2023
iOS/Layover/Layover/Scenes/SettingScene/SettingSceneViewController.swift
Outdated
Show resolved
Hide resolved
loinsir
reviewed
Nov 30, 2023
iOS/Layover/Layover/Scenes/SettingScene/SettingSceneViewController.swift
Show resolved
Hide resolved
loinsir
reviewed
Nov 30, 2023
button.action = #selector(popViewController) | ||
return button | ||
}() | ||
private let settingSceneTableView: UITableView = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tableView 구현 좋습니다. 저희 생각이 통했네요 💪
loinsir
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI 구현 고생하셨습니다. backbutton만 제가 언능 작업하겠습니다.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
설정 뷰 UI를 테이블 뷰로 작업했습니다.
기타 동작들은 프로필에서 프로필 정보를 받아오며 VIP Cycle로 바꿀 때 구현할 예정입니다.
📌 변경 사항
ProfileView에서 연결했습니다.
📸 ScreenShot
UI가 먼가 먼가네요. 피드백 주심 감사하겠슴다.
Linked Issue
close #148