feat: 재생화면 VIP 싸이클 적용 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: iOS/Layover/Layover/Scenes/Home/HomeViewController.swift
Conflicts: iOS/Layover/Layover/Network/DTOs/MemberDTO.swift
Conflicts: iOS/Layover/Layover/Scenes/Home/HomeInteractor.swift iOS/Layover/Layover/Scenes/Home/HomeRouter.swift
|
Branch 이슈로 #146 을 닫았습니다. 이전 리뷰는 해당 pr에서 확인하시면 되겠습니다. |
anyukyung
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
보충 설명을 하자면 VC에서는 presenter로 전달받은 viewModel의 값들을 stopPlayer를 통해 멈추고 playPlayer를 통해 실행시키거나 합니다. playbackCollectionView의 setContentOff를 통해 viewModel값에 있는 indexPath만큼 이동시키거나 합니다.
📌 변경 사항
홈화면과 지도화면에서 재생화면으로 넘어온다고 각 Scene의 코드를 건드린 부분이 있습니다.
잘못건드렸거나 의도에 맞지 않게 수정되었다면 얘기해주시면 얼른 고치겠습니다.
그리고 홈화면과 그 외 화면들 무한 스크롤 방식 차이에 대해서 이야기 하고 싶습니다.
홈화면의 경우 아래로 이동(위로 스와이프) 시 비디오를 로드하는 동작만 넣고 처음 셀로는 이동 안하면 UX적으로 좋을 것 같습니다. 새로고침 하는 느낌?
그 외 화면들은 목록 다 불러와 놓고 한바퀴 도는 형식이 되겠네요
📸 ScreenShot
VIP.mov
VIP.mov
Linked Issue
close #122