Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: MockWorker 의존성 수정 #191

Merged
merged 2 commits into from
Dec 4, 2023
Merged

chore: MockWorker 의존성 수정 #191

merged 2 commits into from
Dec 4, 2023

Conversation

loinsir
Copy link
Collaborator

@loinsir loinsir commented Dec 3, 2023

🧑‍🚀 PR 요약

  • MockWorker 들의 Provider의 authmanager를 stub으로 모두 교체했습니다.
  • EndPointFactory 의존성도 제거하여 주었습니다.

📌 변경 사항

EndPointFactory 의존성도 제거한 이유는 일관성과 Mock 객체인 이상, 다른 객체의 의존을 최대한 덜어내는 것이 좋다고 생각했기 때문입니다.
혹시 더 좋은 의견있으시면 남겨주세요:)

Linked Issue

close #190

@loinsir loinsir self-assigned this Dec 3, 2023
@loinsir loinsir linked an issue Dec 4, 2023 that may be closed by this pull request
fix: Mock Worker authManager 수정 #190
Closed
1 task
chopmozzi
chopmozzi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

chopmozzi
chopmozzi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@loinsir loinsir merged commit 3500b56 into iOS/dev Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyukyung anyukyung anyukyung approved these changes

@chopmozzi chopmozzi chopmozzi approved these changes

Assignees

@loinsir loinsir

Labels
♻️ Improvement 🍎 iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Mock Worker authManager 수정
3 participants
@loinsir @chopmozzi @anyukyung