bug: 재생화면 스택 뷰 재사용 이슈 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b1fc6e338a551588f9edf9926a2530865237197e)
anyukyung
reviewed
Dec 4, 2023
| @@ -62,6 +62,10 @@ final class LOTagStackView: UIStackView { | |||
| addArrangedSubview(button) | |||
| } | |||
|
|
|||
| func resetTag() { | |||
There was a problem hiding this comment.
resetAllTag.. resetTags resetTagStackView..?
There was a problem hiding this comment.
resetTagStackView로 바꿀게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
재생화면에서의 스택뷰 재사용 이슈가 있어 태그 스택뷰를 처리해 주는 작업을 했습니다.
UI에 관련된 내용이므로 prepareforreuse가 아닌 cell configure하는 부분에서 처리했습니다.
짜잘한 리팩토링(줄바꿈, 오타)수정이 있습니다.
📌 변경 사항
없슴다.
📸 ScreenShot
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-12-04.at.20.27.51.mp4
Linked Issue
close #199