feat: 회원가입 시 기존 회원가입 여부 확인 네트워크 연결 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyukyung
reviewed
Dec 6, 2023
Comment on lines
+45
to
+46
| if await worker?.isRegisteredKakao(with: token) == true, | ||
| await worker?.loginKakao(with: token) == true { |
There was a problem hiding this comment.
밑에 메소드랑 통일성 있게 == true 없애도 되지않을까 싶습니다?
There was a problem hiding this comment.
여길 고치려고 하니까 Mock 객체에서 MockURLProtocol.requestHandler 가 static var 이어서 아래쪽이랑 통일하게 되면 data race 때문에 응답이 교차되는 현상이 발생해서 아래를 이것과 똑같이 맞추었습니다...ㅠㅠ
MockURLProtocol.requestHandler를 각 메서드마다 독립적으로 실행하게 되면 나을 것 같은데 우선은 아래를 이것과 통일하도록 할게요
새 이슈에서 진행하겠습니다.
anyukyung
reviewed
Dec 6, 2023
Comment on lines
+106
to
+108
| let endPoint = EndPoint<Response<CheckSignUpDTO>>(path: "/oauth/check-signup/apple", | ||
| method: .POST, | ||
| bodyParameters: bodyParameters) |
There was a problem hiding this comment.
목 워커에서는 따로 엔드포인트 팩토리를 안쓰시는 이유가 있나용
There was a problem hiding this comment.
Mock 객체인 만큼 최대한 다른 객체의 의존성을 덜어주는게 좋다고 생각하기 때문입니다!
그렇지 않으면 EndPointFactory도 검증의 부담이 생기지요
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
회원 가입 시 기존 가입 여부를 확인하는 API 엔드포인트를 연결했습니다.
📌 변경 사항
지금은 True를 MockData로 놓아서 기존 회원가입 화면을 스킵하고 지나갑니다!
Linked Issue
close #217