feat: 지도 탭 업로드 vip 구현 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loinsir
reviewed
Dec 6, 2023
Comment on lines
238
to
239
| self.router?.routeToEditVideo() | ||
| self.videoPickerManager.phPickerViewController.dismiss(animated: true) |
There was a problem hiding this comment.
이거 화면 전환 먼저하고 dismiss 하는 부분 dismiss completion으로 처리안해도 안꼬이나요?
There was a problem hiding this comment.
문제는 없는데 로직상 dissmiss하고 라우팅하는게 나을 것 같아서 순서 바꿔두겠습니당!
loinsir
approved these changes
Dec 6, 2023
화면 전환 순서 수정, 불필요한 self 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
해당 pr에서 작업한 내역을 적어주세요.
videoPickerManager로 분리해서 하도록 했어요!videoPickerManager가PHPickerViewControllerDelegate채택videoPickerManager의VideoPickerDelegate채택PHPickerViewControllerDelegate내부에서VideoPickerDelegate함수 호출📸 ScreenShot
작동, 구현화면
RPReplay_Final1701863448.MP4
Linked Issue
close #225