Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 설정 뷰 VIP 구현 #231

Merged
merged 9 commits into from
Dec 6, 2023
Merged

feat: 설정 뷰 VIP 구현 #231

merged 9 commits into from
Dec 6, 2023

Conversation

loinsir
Copy link
Collaborator

@loinsir loinsir commented Dec 6, 2023 •
edited
Loading

🧑‍🚀 PR 요약

  • 설정 화면 VIP를 구현했습니다.

📌 변경 사항

  • MockWorker가 아닌 실제 Worker를 붙여두었습니다.
  • 약관은 notion에 작성한 페이지를 사파리 웹뷰로 보여주는 것으로 처리했습니다.
  • AlertController를 router가 소유하고 처리하는지 고민했는데, CleanStore를 보니, 뷰컨이 처리하는 것으로 확인해서 동일하게 처리했습니다.
    • AlertController도 UI 컴포넌트로 취급하는 것으로 이해했습니다.
📸 ScreenShot

Simulator Screen Recording - iPhone 15 Pro - 2023-12-06 at 22 48 03

Linked Issue

close #224

@loinsir loinsir self-assigned this Dec 6, 2023
@loinsir loinsir linked an issue Dec 6, 2023 that may be closed by this pull request
feat: 설정 뷰 VIP 구현 #224
Closed
3 tasks
chopmozzi
chopmozzi approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특별한 점 없어보여서 Approve합니다~ UserWorker 잘 동작하나요?

@loinsir
Copy link
Collaborator Author

loinsir commented Dec 6, 2023 •
edited
Loading

특별한 점 없어보여서 Approve합니다~ UserWorker 잘 동작하나요?

아니오...! 지금 확인해보니까 탈퇴가 안되네요 수정해야 할 것 같아요
수정 사항은 여기에 올리겠습니다.

@loinsir
Copy link
Collaborator Author

loinsir commented Dec 6, 2023

수정완료했습니다. 서버 필드명이 userName -> username으로 변경되어서 디코딩 오류네요

anyukyung
anyukyung approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@anyukyung anyukyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 인환님이랑 비슷한 고민을 했었는데요
picker같은 것들도 컴포넌트라고 생각하고 그냥 뷰컨이 가질 수 있도록 했었네요..
수고하셨습니다요 👻

@loinsir loinsir merged commit dc44514 into iOS/dev Dec 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyukyung anyukyung anyukyung approved these changes

@chopmozzi chopmozzi chopmozzi approved these changes

Assignees

@loinsir loinsir

Labels
✨ feature 🍎 iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 설정 뷰 VIP 구현
3 participants
@loinsir @chopmozzi @anyukyung