chore: upload notification 개선 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loinsir
approved these changes
Dec 6, 2023
chopmozzi
approved these changes
Dec 6, 2023
Comment on lines
+74
to
+82
| NotificationCenter.default.addObserver(forName: .uploadTaskStart, object: nil, queue: .main) { [weak self] _ in | ||
| self?.showProgressView() | ||
| } | ||
| NotificationCenter.default.addObserver(forName: .progressChanged, object: nil, queue: .main) { [weak self] notification in | ||
| self?.progressChanged(notification) | ||
| } | ||
| NotificationCenter.default.addObserver(forName: .uploadTaskDidComplete, object: nil, queue: .main) { [weak self] _ in | ||
| self?.removeProgressView() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
해당 pr에서 작업한 내역을 적어주세요.
NotificationQueue를 사용하려고 했는데 프로그레스바에 경우 바로바로 화면에 반영이 되어야해서postingStyle을now로 지정해주어야 했어요now로 지정해주면 동기적으로 동작하는 NotificationCenter에 post하는 것과 동일해서 그냥NotificationCenter에 Post하도록 변경했습니다Linked Issue
close #230