feat: 삭제 기능 추가 #239
Merged
feat: 삭제 기능 추가 #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loinsir
reviewed
Dec 7, 2023
loinsir
reviewed
Dec 7, 2023
loinsir
reviewed
Dec 7, 2023
loinsir
reviewed
Dec 7, 2023
iOS/Layover/Layover/Network/EndPoint/Factories/DeleteReportEndFactory.swift
Outdated
Show resolved
Hide resolved
인환님 리뷰 사항 반영
loinsir
reviewed
Dec 7, 2023
anyukyung
reviewed
Dec 7, 2023
iOS/Layover/Layover/Network/EndPoint/Factories/DeleteReportEndFactory.swift
Outdated
Show resolved
Hide resolved
anyukyung
reviewed
Dec 7, 2023
loinsir
reviewed
Dec 7, 2023
iOS/Layover/Layover/Scenes/Playback/PlaybackViewController.swift
Outdated
Show resolved
Hide resolved
loinsir
reviewed
Dec 7, 2023
|
@loinsir @anyukyung 리뷰 사항 반영했습니다. factory의 경우 PostManagerFactory로 이름 바꿔 관리할 예정입니다. |
anyukyung
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
📌 변경 사항
기존 pr 머지할 때 신고 버튼 넣었던 부분이 지워져서 다시 추가했습니다.
이번 pr도 이전 pr머지 받고 작업하려 했는데 너무 늦어질거 같아서. 이전 pr 머지 받고 충돌 없는지, 누락 된 부분 없는지 체크후 머지하겠습니다.
프로필 뷰도 원래 프로필의 전체 영상을 순회 하려고 했는데, 페이지네이션으로 구현된거 확인 후 무한스크롤 부분 떼주었습니다.
📸 ScreenShot
default.mov
Linked Issue
close #237