Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 홈 테스트 코드 수정 #279

Merged
merged 2 commits into from
Dec 11, 2023
Merged

test: 홈 테스트 코드 수정 #279

merged 2 commits into from
Dec 11, 2023

Conversation

loinsir
Copy link
Collaborator

@loinsir loinsir commented Dec 10, 2023

🧑‍🚀 PR 요약

  • 이미지 로드 방식이 변경됨에 따라 불필요한 썸네일 로드 메서드들을 삭제했습니다.
  • 대신 게시글을 전달할 때 썸네일 이미지 데이터(샘플 이미지)까지 전달하는지 확인하는 테스트 메서드를 추가로 구현했고, MockHomeWorker를 수정했습니다.
image

Linked Issue

close #278

@loinsir loinsir self-assigned this Dec 10, 2023
@loinsir loinsir linked an issue Dec 10, 2023 that may be closed by this pull request
1 task
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged

Comment on lines +44 to +48
let data = responseData.map {
var domainData = $0.toDomain()
domainData.thumbnailImageData = try? Data(contentsOf: imageDataLocation)
return domainData
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@anyukyung anyukyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged

@loinsir loinsir merged commit 7606181 into iOS/dev Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Home 테스트코드 수정
3 participants