✨ feat: HomeViewController 캐러셀 레이아웃 구현 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
anyukyung
reviewed
Nov 16, 2023
anyukyung
reviewed
Nov 16, 2023
chopmozzi
approved these changes
Nov 17, 2023
Comment on lines
+28
to
+31
| let layout = createCarouselLayout(groupWidthDimension: 314/375, | ||
| groupHeightDimension: 473/534, | ||
| maximumZoomScale: 1, | ||
| minimumZoomScale: 473/534) |
There was a problem hiding this comment.
이 상수값들의 기준이 있을까요? 있다면 뷰마다 따로 만들어 둬도 좋을 것 같습니다.
There was a problem hiding this comment.
피그마 값을 기준으로 정했는데, 이곳 처럼 함수로 입력되는 외부 인자도 따로 빼서 관리해줘야 할지 고민이네요... 다같이 논의해봅시다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
HomeViewController 캐러셀 레이아웃을 구현했습니다.
구현하기가 좀 어려웠는데, CompositionalLayout으로 구현했습니다.
Dev Log에 기록해두었는데, 참고하시면 이해하시기 편할듯 합니다.
📸 ScreenShot
작동, 구현화면
Linked Issue
close #21