Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 업로드 태그 개수 제한, 필드 글자수 제한 #283

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

anyukyung
Copy link
Member

@anyukyung anyukyung commented Dec 11, 2023

🧑‍🚀 PR 요약

해당 pr에서 작업한 내역을 적어주세요.

📌 변경 사항

변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.

📸 ScreenShot

작동, 구현화면

RPReplay_Final1702259759.MP4

Linked Issue

close #273

@anyukyung anyukyung self-assigned this Dec 11, 2023
@anyukyung anyukyung changed the title feat feat: 업로드 태그 개수 제한, 필드 글자수 제한 Dec 11, 2023
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 고생하셨습니다.

Comment on lines +282 to +284
guard let originalText = textView.text else { return true }
let newLength = originalText.count + text.count - range.length
return newLength <= Models.contentMaxLength
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +288 to +289
let textCount = textView.text == nil ? 0 : textView.text.count
contentCountLabel.text = "\(textCount)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@loinsir loinsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특별한 문제가 없어서 approve 하겠습니다

@anyukyung anyukyung merged commit 55168bf into iOS/dev Dec 11, 2023
1 check passed
@anyukyung anyukyung linked an issue Dec 11, 2023 that may be closed by this pull request
4 tasks
@anyukyung anyukyung deleted the iOS/feat#273 branch January 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 업로드 태그 개수 제한, 필드 글자수 제한
3 participants