feat: 재생화면 뷰 구현(UI) #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loinsir
reviewed
Nov 16, 2023
|
|
||
| import UIKit | ||
|
|
||
| final class LODescriptionView: UIView { |
anyukyung
reviewed
Nov 16, 2023
Comment on lines
37
to
39
| descriptionLabel.textColor = .layoverWhite | ||
| descriptionLabel.font = .loFont(type: .body2) | ||
| descriptionLabel.numberOfLines = 0 |
anyukyung
reviewed
Nov 16, 2023
Comment on lines
41
to
42
| self.addSubview(descriptionLabel) | ||
| self.addSubview(titleLabel) |
There was a problem hiding this comment.
만들어둔 addsubviews 사용하면 좋을 것 같습니다!
loinsir
reviewed
Nov 16, 2023
Comment on lines
16
to
21
| self.minimumTrackTintColor = .primaryPurple | ||
| setThumbImage(UIImage(named: normalThumbImage), for: .normal) | ||
| self.minimumValue = 1 | ||
| self.maximumValue = 100 | ||
| self.value = 50 | ||
|
|
There was a problem hiding this comment.
함수로 감싸주세요....
minimumValue, maximumValue는 여기서 설정해줘도 될까요?
There was a problem hiding this comment.
일단 레이아웃 뷰 배치만 하려고 임시로 설정했습니다.
anyukyung
reviewed
Nov 16, 2023
Comment on lines
11
to
12
| private let normalThumbImage: String = "LONormalThumb" | ||
| private let selectedThumbImage: String = "LOSelectedThumb" |
There was a problem hiding this comment.
UISlider에 thumb는 UIImage로 밖에 못 넣는거 같아서.. 좀 더 확인해보겠습니다.
loinsir
reviewed
Nov 16, 2023
Comment on lines
11
to
12
| private let normalThumbImage: String = "LONormalThumb" | ||
| private let selectedThumbImage: String = "LOSelectedThumb" |
There was a problem hiding this comment.
resource loader 사용하시면 될 듯 해서 없어도 될 코드 인 것 같습니다.
아래에 후술할게요
loinsir
reviewed
Nov 16, 2023
| } | ||
|
|
||
| override func beginTracking(_ touch: UITouch, with event: UIEvent?) -> Bool { | ||
| setThumbImage(UIImage(named: selectedThumbImage), for: .normal) |
There was a problem hiding this comment.
setThumbImage(UIImage.selectedThumbImage, for: .normal
loinsir
reviewed
Nov 16, 2023
Comment on lines
24
to
26
| required init?(coder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") | ||
| } |
There was a problem hiding this comment.
코드 연쇄살인마를 위해 fatalError외에 구현해주세요...
loinsir
reviewed
Nov 16, 2023
Comment on lines
+37
to
+42
| var config = UIButton.Configuration.plain() | ||
| config.titleTextAttributesTransformer = UIConfigurationTextAttributesTransformer { incoming in | ||
| var outgoing = incoming | ||
| outgoing.font = UIFont.loFont(type: .body2Bold) | ||
| return outgoing | ||
| } |
anyukyung
reviewed
Nov 16, 2023
| button.layer.cornerRadius = 19 | ||
| button.layer.borderWidth = 1 | ||
| button.layer.borderColor = UIColor.layoverWhite.cgColor | ||
| // button.setImage(UIImage(systemName: "cancel"), for: .normal) |
There was a problem hiding this comment.
얘 언젠간 쓸거 같아서... 프로필 이미지를 위해 남겨놨습니다.
anyukyung
reviewed
Nov 16, 2023
Comment on lines
+109
to
+121
| private func setup() { | ||
| let viewController = self | ||
| let interactor = PlaybackInteractor() | ||
| let presenter = PlaybackPresenter() | ||
| let router = PlaybackRouter() | ||
|
|
||
| viewController.router = router | ||
| viewController.interactor = interactor | ||
| interactor.presenter = presenter | ||
| presenter.viewController = viewController | ||
| router.viewController = viewController | ||
| router.dataStore = interactor | ||
| } |
There was a problem hiding this comment.
하는김에 configurator 만들어서 분리해도 좋을 것 같습니다
There was a problem hiding this comment.
얘는 뷰모델 받아와서 뷰 구성하는 작업할 때 따로 이슈로 만들어서 처리할게요~
✨ feat: HomeViewController 캐러셀 레이아웃 구현
|
Approve "해줘"주세요.. |
anyukyung
reviewed
Nov 19, 2023
Comment on lines
21
to
38
| // MARK: - Properties | ||
|
|
||
| private (set) var titleLabel: UILabel = { | ||
| let label: UILabel = UILabel() | ||
| label.numberOfLines = 1 | ||
| label.font = .loFont(type: .body1) | ||
| label.textColor = .layoverWhite | ||
| label.text = "제목 테스트" | ||
| return label | ||
| }() | ||
| private (set) var descriptionLabel: UILabel = { | ||
| let label: UILabel = UILabel() | ||
| label.textColor = .layoverWhite | ||
| label.font = .loFont(type: .body2) | ||
| label.numberOfLines = 0 | ||
| return label | ||
| }() | ||
|
|
There was a problem hiding this comment.
Ready only로 쓰려고 private (set) var를 했는데 이렇게 쓸거면 private 풀고 let 박아두는게 나을거 같아서 수정했습니다 감사합니다.
anyukyung
reviewed
Nov 19, 2023
Comment on lines
55
to
57
| descriptionLabel.textColor = .layoverWhite | ||
| descriptionLabel.font = .loFont(type: .body2) | ||
| descriptionLabel.numberOfLines = 0 |
There was a problem hiding this comment.
선언시에 처리해주는 걸로 수정하셨으니 이부분은 이제 삭제해도 괜찮지 않을까요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
📌 변경 사항
내용 소개가 이상함...
📸 ScreenShot
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-11-17.at.01.15.33.mp4
Linked Issue
close #9