Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: memberID 요청 전, 토큰을 저장하지 않았던 버그 수정 #313

Merged
merged 2 commits into from
Dec 12, 2023
Merged

bug: memberID 요청 전, 토큰을 저장하지 않았던 버그 수정 #313

merged 2 commits into from
Dec 12, 2023

Conversation

loinsir
Copy link
Collaborator

@loinsir loinsir commented Dec 12, 2023

🧑‍🚀 PR 요약

  • memberID 요청 전, 토큰을 먼저 저장하지 않고 요청을 보냈던 오류를 수정했습니다.

📌 변경 사항

  • 로그인 메서드에서 memberID 필드를 분리했습니다.

Linked Issue

close #312

@loinsir loinsir self-assigned this Dec 12, 2023
chopmozzi
chopmozzi approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 유경님 리뷰 리퀘스트 안되어있는거 같은데 확인 부탁드려요

iOS/Layover/Layover/Scenes/Login/LoginWorker.swift Outdated
loginType: .kakao)
authManager.memberID = await fetchMemberId()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchMemberID

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다~

chopmozzi

This comment was marked as duplicate.

Sign in to view

@loinsir loinsir requested a review from anyukyung December 12, 2023 07:54
@loinsir loinsir linked an issue Dec 12, 2023 that may be closed by this pull request
bug: 로그인 시 memberId 요청 전 accessToken 미저장 이슈 해결 #312
Closed
1 task
anyukyung
anyukyung approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@anyukyung anyukyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 💨💨

@loinsir loinsir merged commit 35779bd into iOS/dev Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyukyung anyukyung anyukyung approved these changes

@chopmozzi chopmozzi chopmozzi approved these changes

Assignees

@loinsir loinsir

Labels
🐞 bug 🍎 iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: 로그인 시 memberId 요청 전 accessToken 미저장 이슈 해결
3 participants
@loinsir @chopmozzi @anyukyung