chore: 재생 로직 구조 변경 #342
Closed
chore: 재생 로직 구조 변경 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
베이스 브랜치 바꿔주셔야 할 것 같습니다. 테스트 전부 통과하나요? |
|
@loinsir 네 빌드 상에서는 작성된 테스트 코드들 다 동작은 합니다. |
anyukyung
reviewed
Jan 10, 2024
iOS/Layover/LayoverTests/Mocks/Workers/PlaybackInteractorTests.swift
Outdated
Show resolved
Hide resolved
anyukyung
reviewed
Jan 10, 2024
iOS/Layover/LayoverTests/Mocks/Workers/PlaybackInteractorTests.swift
Outdated
Show resolved
Hide resolved
anyukyung
approved these changes
Jan 10, 2024
헉 테스트...가 통과하지 않네요 ㅠㅠ
테스트 중간중간에 Task sleep 추가하신 이유가 있을까요? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
재생 로직 구조를 변경했습니다. Task -> async
하는 김에 겸사겸사 테스트도 했습니다.
Linked Issue
close #336